Add unit tests for code view utilities and highlighter #221
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| @Test | ||
| public void applyJavaTheme_resetsPatternsAndReHighlights() { | ||
| CodeView codeView = mock(CodeView.class); | ||
|
|
||
| CodeHighlighter.applyJavaTheme(codeView); | ||
|
|
||
| InOrder order = inOrder(codeView); | ||
| order.verify(codeView).resetSyntaxPatternList(); | ||
| order.verify(codeView).resetHighlighter(); | ||
| order.verify(codeView, times(5)).addSyntaxPattern(any(Pattern.class), anyInt()); | ||
| order.verify(codeView).reHighlightSyntax(); | ||
| } | ||
|
|
||
| @Test | ||
| public void applyXmlTheme_resetsPatternsAndReHighlights() { | ||
| CodeView codeView = mock(CodeView.class); | ||
|
|
||
| CodeHighlighter.applyXmlTheme(codeView); | ||
|
|
||
| InOrder order = inOrder(codeView); | ||
| order.verify(codeView).resetSyntaxPatternList(); | ||
| order.verify(codeView).resetHighlighter(); | ||
| order.verify(codeView, times(4)).addSyntaxPattern(any(Pattern.class), anyInt()); | ||
| order.verify(codeView).reHighlightSyntax(); |
There was a problem hiding this comment.
[P1] Avoid Android framework calls in host-unit tests
Both new tests execute CodeHighlighter.apply*Theme, which internally calls android.graphics.Color.parseColor. Because these tests live under app/src/test/java they run on the host JVM without an Android runtime or Robolectric, so parseColor will throw RuntimeException("Stub!") and the suite will fail even when the SDK is installed. Consider moving these checks to androidTest or adding Robolectric/mocking the color parsing so the tests can run in the existing unit-test environment.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68c97659fc2c832d88f764f29d83fc35